Add ESM2 Data Module #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjohn
reviewed
Jul 29, 2024
| import numpy.typing as npt | ||
|
|
||
|
|
||
| class Item(TypedDict): |
There was a problem hiding this comment.
Maybe BertBatchRow or something?
pstjohn
force-pushed
the
pstjohn/v2-main/esm_data_module
branch
2 times, most recently
from
f7adab8 to
92c95cc
Compare
pstjohn
changed the base branch from
v2-main
to
pstjohn/v2-main/masking-and-tokenizer
pstjohn
force-pushed
the
pstjohn/v2-main/masking-and-tokenizer
branch
from
a4da493 to
849878d
Compare
jstjohn
reviewed
Aug 1, 2024
|
|
||
| mask_prob: float = 0.15 | ||
| mask_token_prob: float = 0.8 | ||
| random_token_prob: float = 0.1 |
There was a problem hiding this comment.
Recommendation:
Add a post_init that checks that (mask_token_prob + random_token_prob) <= 1 as well as 0 <= mask_prob <= 1
pstjohn
force-pushed
the
pstjohn/v2-main/masking-and-tokenizer
branch
6 times, most recently
from
c03d718 to
870e7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions for loading and pre-processing protein sequences