-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change source for coverage report #495
Conversation
/build-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peter could you just copy paste what a sample output looks like from this? Probably it works I just want to double check...
@trvachov Sure thing, this is from https://prod.blsm.nvidia.com/bionemo-external-bionemo-fw/job/test_pytest/966/pipeline-console/?selected-node=66
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Suggest making the coverage report command clearer.
Signed-off-by: Peter St. John <[email protected]>
/build-ci |
Late to approve, but thanks for merging (my comments were NITs mostly). |
Corrects the
source
field for the coverage report, prints out which lines are missed.