Use self-hosted azure runners for bionemo unit tests #560
Conversation
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
from
0c864e0 to
af85a9d
Compare
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
4 times, most recently
from
b910cfa to
d2d08f4
Compare
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
from
4ac20e0 to
818f4dc
Compare
pstjohn
requested review from
DejunL,
farhadrgh,
guoqing-zhou and
skothenhill-nv
as code owners
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
2 times, most recently
from
c4c2284 to
12e09d6
Compare
|
Looks like
|
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
2 times, most recently
from
781a8f2 to
df87ab1
Compare
pstjohn
changed the title
Signed-off-by: Peter St. John <[email protected]>
pstjohn
force-pushed
the
pstjohn/self-hosted-runner-action
branch
from
df87ab1 to
7633699
Compare
| # Function to handle cleanup on script exit | ||
| cleanup() { | ||
| local exit_code=$? | ||
| [ -n "${coverage_files[*]:-}" ] && rm -f "${coverage_files[@]:-}" | ||
| exit "$exit_code" | ||
| } | ||
|
|
There was a problem hiding this comment.
We need these coverage files to persist to the next step in the GHA actions pipeline so we can upload them to codecov. Do these stick around on the blossom workers?
| path: ${{ github.run_id }} | ||
|
|
||
| - name: Run tests | ||
| run: ./ci/scripts/run_pytest.sh --no-nbval |
There was a problem hiding this comment.
we could eventually make this configurable based on the PR label 🤷 . But I wonder how that interacts with code coverage diffs. I.e., I wouldn't want to flag a PR as "decreasing coverage" because we didn't run notebook tests...
| path: ${{ github.run_id }} | ||
|
|
||
| - name: Run tests | ||
| run: ./ci/scripts/run_pytest.sh --no-nbval |
There was a problem hiding this comment.
could you add here mechanism for PR labels: SKIP_CI and INCLUDE_NOTEBOOKS_TESTS to define the scope of tests or omit them completely?
|
Testing from a branch rather than a fork in #587 |
No description provided.