Pbinder/move scdl #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build-ci |
polinabinder1
requested review from
skothenhill-nv
and removed request for
jstjohn
pstjohn
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Just a nit, but any reason you need to have this file and the version specified in the pyproject.toml?
Could you instead see if
from importlib.metadata import version
version('bionemo-scdl')would let you have the version tag in only one place?
There was a problem hiding this comment.
Oh, they should be in the same one. Good point.
sub-packages/bionemo-scdl/setup.py
Outdated
Comment on lines
20
to
37
| setup( | ||
| name="scdl", | ||
| version="0.0.1", | ||
| packages=find_packages(), | ||
| author="NVIDIA Corporation", | ||
| author_email="[email protected]", | ||
| description="A library for fast dataloading of single cell data.", | ||
| long_description="scdl is a library for reading and writing performant datasets from single cell foundation models.", | ||
| url="", | ||
| classifiers=[ | ||
| "Development Status :: 3 - Alpha", | ||
| "Intended Audience :: Developers", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| ], | ||
| python_requires=">=3.10", | ||
| install_requires=[], | ||
| ) |
There was a problem hiding this comment.
@malcolmgreaves -- do we still need a setup.py script? why isn't the pyproject.toml sufficient?
|
/build-ci |
|
|
||
| Alternatively, it can be installed with | ||
| ```bash | ||
| pip install bionemo[scdl] |
scripts/convert_h5ad_to_scdl.py
Outdated
Comment on lines
1
to
11
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: LicenseRef-Apache2 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, |
There was a problem hiding this comment.
Is this a duplicate of the module level sub-package/bionemo-scdl/scripts/convert_h5ad_to_scdl.py ?
skothenhill-nv
approved these changes
Aug 6, 2024
jstjohn
approved these changes
Aug 7, 2024
|
/build-ci |
2 similar comments
|
/build-ci |
|
/build-ci |
polinabinder1
force-pushed
the
pbinder/move_scdl
branch
from
b67ae19 to
6c3747c
Compare
|
/build-ci |
|
/build-ci |
|
/build-ci |
1 similar comment
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the scdl changes over.