Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post-create command #88

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix post-create command #88

merged 2 commits into from
Aug 9, 2024

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Aug 9, 2024

Getting the following error locally building the devcontainer:

ERROR: file:///workspaces/bionemo-fw-ea/sub-packages/bionemo.egg-info does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

This seems to fix it

@pstjohn pstjohn self-assigned this Aug 9, 2024
@pstjohn
Copy link
Collaborator Author

pstjohn commented Aug 9, 2024

/build-ci

@skothenhill-nv
Copy link
Collaborator

LGTM, repeating our conversation on slack:

@skothenhill-nv
"""
can we define the sub-packages in the top level pyproject.toml or something? I hit this issue all the time, typically when I checkout an older PR or something and it leaves a mess
"""

@pstjohn
"""
we changed from doing that because we wanted to make it easier to add new ones
"""

@pstjohn
Copy link
Collaborator Author

pstjohn commented Aug 9, 2024

/build-ci

Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pstjohn pstjohn merged commit 56e6484 into v2-main Aug 9, 2024
2 checks passed
@pstjohn pstjohn deleted the pstjohn/v2-main/postCreatefix branch September 16, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants