Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static_multimap_ref::for_each #599

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add static_multimap_ref::for_each #599

merged 2 commits into from
Sep 17, 2024

Conversation

sleeepyjack
Copy link
Collaborator

This PR enables the device for_each operator for static::experimental::multimap.

@sleeepyjack sleeepyjack added type: feature request New feature request P1: Should have Necessary but not critical Needs Review Awaiting reviews before merging topic: static_multimap Issue related to the static_multimap labels Sep 5, 2024
@sleeepyjack sleeepyjack self-assigned this Sep 5, 2024
PointKernel
PointKernel reviewed Sep 14, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick otherwise looks great.

include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
PointKernel
PointKernel approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleeepyjack sleeepyjack merged commit 9ef3535 into NVIDIA:dev Sep 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

Assignees

@sleeepyjack sleeepyjack

Labels
Needs Review Awaiting reviews before merging P1: Should have Necessary but not critical topic: static_multimap Issue related to the static_multimap type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleeepyjack @PointKernel