Draft: Support DataStore V2 #286
Conversation
shengnuo
requested review from
ArangoGutierrez,
shivamerla and
visheshtanksale
as code owners
| State string `json:"state,omitempty"` | ||
| } | ||
|
|
||
| type NemoDatastoreV2Params struct { |
There was a problem hiding this comment.
we should split these into "db", "objectStore", "storage", "sshService" types. And map underlying values as done in the helm chart. Params itself need not be same as helm chart values.
There was a problem hiding this comment.
It's difficult to categorize the pre-existing secrets into these categorize like the NeMo datastore helmchart..
Some of the pre-existing secrets come with the helmcharts, and they don't seem to be tied to neither "db", "objectStore", "storage", nor "sshService. For example, datastoreInitSecret contains the shell script for initializing datastore volumes.
We can discuss further during the demo
There was a problem hiding this comment.
Another option would be to make the NeMo datastore controller fetch and deploy the nemo datastore helmchart... so that the datastore CR can be formatted exactly like the helm chart values file
shengnuo
force-pushed
the
dsv2
branch
2 times, most recently
from
55ee5ce to
d16ae69
Compare
Signed-off-by: Sheng Lin <[email protected]>
Signed-off-by: Sheng Lin <[email protected]>
Signed-off-by: Sheng Lin <[email protected]>
New API for supporting DataStore V2
Sample CR can be found at
config/samples/apps_v1alpha1_nimdatastorev2.yamlpre-requisite components:
Secrets as specified in
.spec.dataStoreParamsthat need to be created before deploying DataStore microservice