Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New datasets framework #111

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Jan 31, 2023

Datasets have been reformatted in this MR to support easy adding of new datasets.

  • All datasets should subclass WispDataset, which returns a Batch instance from __get_item__
  • Underneath WispDataset, abstract MultiviewDataset and SDFDataset define more specific interfaces.
  • NeRFSyntheticDataset and RTMVDataset are new concrete classes, which return a MultiviewBatch.
  • Previous SDFDataset separated to concrete classes MeshSampledSDFDataset and OctreeSampledSDFDataset, depending on whether samples are generated directly from mesh or limited by the octree narrowband. Both return a SDFBatch.
  • load_multiview_dataset is a convenience method that looks at a given path and tries to determine the correct MultiviewDataset subclass to create (out of all available dataset subclasses). This relies on the optional is_root_of_dataset() @classmethod each dataset may implement to distinguish itself from other formats.

Signed-off-by: operel [email protected]

Mesh datasets + sdf batches + collate

Remove deprecated files

Bug fixes and support for validation splits

Interface datasets better

RTMV fix

Dataset docs

some bug fixes

fixes for demo

MR with rebased main

MR fixes

fix flakey test

Signed-off-by: operel <[email protected]>

README.md updates

Signed-off-by: operel <[email protected]>
@orperel orperel changed the title NeRF and RTMV datasets New datasets framework Jan 31, 2023
@orperel orperel merged commit 368bd52 into NVIDIAGameWorks:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant