Hashgrid PyTorch implementation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orperel
approved these changes
Mar 23, 2023
|
Looks great, thanks for fixing this @alvaro-budria ! :) |
orperel
pushed a commit
to AvivSham/kaolin-wisp
that referenced
this pull request
May 30, 2023
The current PyTorch reference implementation of the hash grid interpolation in `wisp` is not correct (incorrect prime, and code out of date). This PR resolves: NVIDIAGameWorks#129).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PyTorch implementation of the hash grid interpolation in
wispis not correct. I modified it and tested it by executingIt seems it's producing the same results as the default CUDA implementation after training for 50 epochs:
I noticed that in the original implementation in
wisp, the coordinates are hashed by rolling the prime on the dimension index:cc[...,0] * PRIMES[(i*3+0)%len(PRIMES)]but in https://github.com/NVlabs/tiny-cuda-nn/blob/master/include/tiny-cuda-nn/encodings/grid.h, function
lcg_hash, they just keep each prime fixed to a dimension, which is what I do here.This PR resolves this issue.