-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validator bag when closing tag is not opened. #647
Merged
amitguptagwl
merged 2 commits into
NaturalIntelligence:master
from
RyosukeFukatani:fix/not_opened_tag
Mar 24, 2024
Merged
fix: validator bag when closing tag is not opened. #647
amitguptagwl
merged 2 commits into
NaturalIntelligence:master
from
RyosukeFukatani:fix/not_opened_tag
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyosukeFukatani
changed the title
[WIP] fix validator bag the case tag is not opened.
fix validator bag the case tag is not opened.
Mar 19, 2024
RyosukeFukatani
changed the title
fix validator bag the case tag is not opened.
fix: validator bag when closing tag is not opened.
Mar 19, 2024
RyosukeFukatani
changed the title
fix: validator bag when closing tag is not opened.
[WIP] fix: validator bag when closing tag is not opened.
Mar 19, 2024
Thanks for your changes. Will wait until the PR is marked as WIP |
@amitguptagwl I believe that this PR will make the benchmark hardly any worse.
|
You can ignore benchmarking for this change :) |
RyosukeFukatani
changed the title
[WIP] fix: validator bag when closing tag is not opened.
fix: validator bag when closing tag is not opened.
Mar 20, 2024
@amitguptagwl |
|
@amitguptagwl |
amitguptagwl
merged commit Mar 24, 2024
a96b968
into
NaturalIntelligence:master
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Fixes #620
fxparser -V a.xml
with input.xml.On current master.
With this change.
Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]
in PR title. Your PR will be reviewed when[WIP]
will be removed from the PR title.Bookmark this repository for further updates.