Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #634: build attributes with oneListGroup and attributesGroupName #653

Conversation

a-rasin
Copy link
Contributor

@a-rasin a-rasin commented May 6, 2024

Don't ignore attributes when building to xml with oneListGroup and attributesGroupName enabled.

Purpose / Goal

Fixes #634

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

…ttributesGroupName

Don't ignore attributes when building to xml with oneListGroup and
attributesGroupName enabled.
@coveralls
Copy link

Coverage Status

coverage: 98.266% (+0.006%) from 98.26%
when pulling 77f8aa3 on a-rasin:master
into 9118736 on NaturalIntelligence:master.

@amitguptagwl
Copy link
Member

Somehow this build is failing everytime.

@coveralls
Copy link

Coverage Status

coverage: 98.175% (+0.007%) from 98.168%
when pulling 52241a4 on a-rasin:updated-oneListGroup-plus-attributes
into 931e910 on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit acf610f into NaturalIntelligence:master Jul 10, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute in oneListGroup is not parsed correctly
3 participants