Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add trend image #658

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

cwtuan
Copy link
Contributor

@cwtuan cwtuan commented Jun 15, 2024

Thank you for maintaining the fast-xml-parser package. It has been an invaluable tool in my projects, and I truly appreciate the hard work you and the contributors have dedicated to its development.

As an user of this package, I would like to suggest a small enhancement to the README that I believe could benefit potential users. Specifically, I propose adding a trend image. It will visually show the increasing popularity of the fast-xml-parser package over recent years.

New users often look for signs of a well-maintained and widely-used package. A positive download trend can be a persuasive factor. Also, highlighting the growth of the package can encourage more contributions from the community.

Thank you for considering my suggestion.

Here's a preview:

image

@amitguptagwl
Copy link
Member

Thanks for the PR. no doubt it can be helpful but the download trends is already present on npm so it'll be helpful for only Github users. Currently, there are lot of contents on the README. And I don't want to push the contents down more. So I was wondering to reduce the size of the graph and move it to graph section.

@cwtuan
Copy link
Contributor Author

cwtuan commented Jun 16, 2024

Thank you for your prompt response and for considering my suggestion.

I've reduced the graph width to 50% and moved it to follow the Performance section as suggested. Please review the updated PR at your convenience, and let me know if there are any further adjustments or improvements needed.

Note that while the download trends present on npm are helpful, they only display data for the past year. Adding a longer-term trend graph to the README will visually capture the increasing popularity of the fast-xml-parser package over several years, which might be more persuasive for potential users and contributors.

Thank you again for your guidance.

Here is preview:

image

@amitguptagwl amitguptagwl merged commit a6265ba into NaturalIntelligence:master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants