Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes entity parsing when used in strict mode #699

Conversation

jhulford
Copy link
Contributor

Purpose / Goal

Fixes issue 698 that results in a reference error of entityName is not defined being raised when run in strict mode - such as when using via an esm module import.

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

@coveralls
Copy link

Coverage Status

coverage: 98.212%. remained the same
when pulling ae43748 on jhulford:fix-entity-parsing-in-strict-mode
into 4082902 on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 74e2651 into NaturalIntelligence:master Dec 14, 2024
8 of 9 checks passed
@amitguptagwl
Copy link
Member

Thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants