Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix for broken Products.Get() api #25

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

zveinn
Copy link
Contributor

@zveinn zveinn commented Mar 23, 2024

It seems lemon is now returning Price as a string.. even though their documentation says it's an int.

This might break again later when lemon realizes that they changed the data type ( assuming it's an accidental change )

product.go Outdated Show resolved Hide resolved
@AchoArnold AchoArnold merged commit 78d640c into NdoleStudio:main Mar 24, 2024
4 checks passed
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (81f23ab) to head (05dbc2f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          23       23           
  Lines         575      575           
=======================================
  Hits          466      466           
  Misses         56       56           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AchoArnold
Copy link
Member

Thanks @zveinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants