-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New standard mobile-first skin #1654
Comments
Dual renderer for paging skin block can be a backward-compatible solution. |
- Work in progress. - We need some template language for skins. Currently we have to modify PHP codes to change HTML markups, but if we have a template engine, the modification can be confined within HTML only. Example: <li [##_no_more_prev_##]><a ... dress('no_more_prev', isset($paging['prev']) ? '' : 'class="disabled"', $view, $useSkinCache); can be rewritten as (following Jinja's syntax): <li{% if no_more_prev %} class="disabled"{% endif %}><a ...
Just for memo. Considerations for a new skin specification:
|
Paging is handled by library/view/paging.php. getPagingView receives paging skin fragment, parses and returns the complete html. Therefore I'll work on
|
@achimnol I strongly agree with your opinion about CSS namespace. Currently, textcube skin support some default CSS names and ids, hardcoded in core (/skin/blog/standard/style.css uses them) without namespace. (Well, it's 10 year old code.) Any ideas for naming? tc (textcube)? cb (codeball)? nw (needlworks)? |
@achimnol I'll look at your modified pagination html markup of your test page. If you can send me a simplified html ul-li pagination format, please attach it here. 👍 |
I think Additional idea for the new skin format:
|
- i/ and m/ URLs are removed. From now on, textcube loads skin/blog/lucid when - blog.useiPhoneMode is true - device agent is recognized as the one of mobile devices. TODO: - mobile <-> desktop mode button - move skin location to under resource/ directory. - upgrade skin parser to read skins outside /skin/blog directory. - Lots of mobile skin design / functions
- default skin location (/skin/default) added. - Mobile mode uses skin at /skin/default/lucid.
- Readjust the content font size - Fixed - coverpage view img size for mobile - Fixed - input form layout
- Readjust the content font size - Fixed - coverpage view img size for mobile - Fixed - input form layout
CSS, does not rely on MT_Meta_Recent Plugin
CSS, does not rely on MT_Meta_Recent Plugin
Build a new standard skin with mobile-first in mind.
The skin will be based on Bootstrap 3.x or later, its jQuery plugins, and Font Awesome 4.x or later.
To use this skin for mobile phones, we need to force use of the blog skin instead of "i" or "m" mode. In particular, the "m" mode for old feature-phones is considered to be deprecate.
We also need to modify Textcube's core codes that are tightly coupled with HTML rendering, such as pagination and category badges.
After all modifications, old skins may not be compatible with the new version of Textcube, but we will try to minimize backward-incompatibility.
The text was updated successfully, but these errors were encountered: