Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal pop-up dialog for comment reply, delete, modify UI #1725

Open
inureyes opened this issue Dec 17, 2014 · 7 comments
Open

modal pop-up dialog for comment reply, delete, modify UI #1725

inureyes opened this issue Dec 17, 2014 · 7 comments
Assignees
@inureyes
Labels
enhancement
Milestone
2.0.0

Comments

@inureyes
Copy link
Member

Summary

  • modal pop-up dialog for comment reply, delete, modify UI
  • Using jQuery
@inureyes inureyes self-assigned this Dec 17, 2014
@inureyes inureyes added this to the 1.10.1 milestone Dec 17, 2014
@inureyes
Copy link
Member Author

Requirements

  • Proper jQuery plugin (should handle iframe) -> bPopup
  • Dialog element in DOM (#tcDialog?) -> #tcDialog
  • openWindow function -> openDialog function (in common2.js)
  • Error handling
  • Close modal pop-up at the end of tasks (e.g. comment to comment saved)

inureyes added a commit that referenced this issue Dec 17, 2014
@inureyes
refs #1725 : enhanced - modal pop-up comment related windows.
529855d 
 -
@zvuc
Copy link
Contributor

zvuc commented Dec 17, 2014

페이지 내에 팝업을 띄우게 된다면 사용자가 디자인을 쉽게 변경할 수 있도록 CSS로 선택 가능한 클래스명을 지정하거나 skin.html에 해당 부분을 넣어 스킨의 디자인에 따라 default레이아웃 구조를 변경할 수 있도록 할 수 있게 함이 어떨까 합니다.

@achimnol
Copy link
Member

드디어 해묵은(...) 논의거리였던 CSS namespace의 필요성이 나오는군요. "textcube-"와 같은 prefix를 붙여서 텍큐 쪽이 제공하는 기본 UI 디자인을 해두고 사용자가 원하면 override할 수 있게 하자는 아이디어....ㅎㅎ
그리고 가능하면 id보다는 class를 위주로 사용했으면 좋겠습니다. 다이얼로그 창 안에서 또 다이얼로그가 뜬다거나 이런 상황도 생길 수 있으니까요.

@zvuc
Copy link
Contributor

zvuc commented Dec 17, 2014

네, 애초에 새로운 규격을 추가해버리면 그 부분이 없었던 기존 스킨은 못 쓰게 되어버리니 기본 스타일을 출력하고 CSS에서 잡아서 오버라이드만 할수 있어도 충분하지 않나 싶습니다 ㅋㅋ iframe만 아니라면야(..)

inureyes added a commit that referenced this issue Dec 17, 2014
@inureyes
refs #1725 : bugfix - modal worked only with flash clipboard poter
a1f0a16 
 -
inureyes added a commit that referenced this issue Dec 17, 2014
@inureyes
refs #1725 : bugfix - typo -_-;
c11c9de 
 -
@inureyes
Copy link
Member Author

@achimnol @zvuc 현재 구현은, 팝업을 호환성을 위해 그대로 남겨두고 iframe을 사용해서 modal dialog를 얹어놓은 구현 형태입니다. 따라서 기존 디자인을 그대로 따라가게 되어 있지요. ;;

2.0에서 CSS namespace 문제를 해결합시다. 1.10에 뭔가 더 정성을 쏟으면 벌써 오 년 넘게 이어지고 있는 '두 개발트리' 상태에서 못 벗어날 듯... ㅎㅎ

inureyes added a commit that referenced this issue Dec 18, 2014
@inureyes
refs #1725 : modified - narrow button design.
5c992da 
 -
inureyes added a commit that referenced this issue Dec 22, 2014
@inureyes
refs #1725 : added - more browser / OS checks to common2.js.
6c724a1 
 -
inureyes added a commit that referenced this issue Dec 22, 2014
@inureyes
refs #1725 : added - if browser < IE8, use pop-up.
7deef24 
 -
inureyes added a commit that referenced this issue Dec 22, 2014
@inureyes
refs #1725 : added - mobile mode uses pop-up routine. (another window)
359a48e 
 -
@achimnol achimnol mentioned this issue Dec 23, 2014
Closed
inureyes added a commit that referenced this issue Dec 30, 2014
@inureyes
refs #1725 : bugfix - admin panel also support modal pop-up.
174fed6 
 -
inureyes added a commit that referenced this issue Dec 30, 2014
@inureyes
refs #1725 : added - mobile popup CSS / images.
9b0a2d8 
 -
@inureyes
Copy link
Member Author

inureyes commented Jan 4, 2015

When using mobile-support skins (e.g. periwinkle), pop-up does not call.

With mobile-support skin, textcube recognize current display mode as desktop. Therefore comment-to-comment script call modal pop-up.

inureyes added a commit that referenced this issue Jan 5, 2015
@inureyes
refs #1725 : modified - responsive skins also uses pop-up comment.
a612fec 
 - added - var workMode
   * 'standard' : uses legacy interfaces.
   * 'enhanced' : uses javascript-rich expressions. (e.g. modal dialogs.)
inureyes added a commit that referenced this issue Jan 5, 2015
@inureyes
refs #1725 : modified - pop-up window looked ugly on mobile.
550d5dc 
 -
inureyes added a commit that referenced this issue Jan 6, 2015
@inureyes
refs #1725 : upstream to master.
19c4d5d 
 -

 refs #1725 : bugfix - modal worked only with flash clipboard poter

 -

 refs #1725 : bugfix - typo -_-;

 -

 refs #1725 : modified - narrow button design.

 -

 refs #1725 : added - if browser < IE8, use pop-up.

 -

 refs #1725 : added - mobile mode uses pop-up routine. (another window)

 -

 refs #1725 : bugfix - admin panel also support modal pop-up.

 -

 refs #1725 : added - mobile popup CSS / images.

 -

 refs #1725 : modified - responsive skins also uses pop-up comment.

 - added - var workMode
   * 'standard' : uses legacy interfaces.
   * 'enhanced' : uses javascript-rich expressions. (e.g. modal dialogs.)

 refs #1725 : modified - pop-up window looked ugly on mobile.

 -
inureyes added a commit that referenced this issue Jan 6, 2015
@inureyes
refs #1725 : modified - master-compatible grammar.
84a8261 
 -
@inureyes inureyes modified the milestones: 1.10.1, 2.0.0 Jan 11, 2015
@inureyes
Copy link
Member Author

Disable ESC / modal click to prevent blow-up comments by unintended clicks.

Suggested by @pat-al http://notice.textcube.org/ko/269?commentId=127273#comment127273

inureyes added a commit that referenced this issue Jan 17, 2015
@inureyes
refs #1725 : added - close function to modal window.
372dd2d 
 -
inureyes added a commit that referenced this issue Jan 17, 2015
@inureyes
refs #1725 : added - close button.
964c8e5 
 - TODO : Design for close button.
 - TODO : Add button on modify/delete view.
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
refs #1725 : added - close button on delete / modify pop-up (modal)
0d217f3 
 -
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
refs #1725 : modified - disable esc / modal click close.
0164b33 
 -
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
refs #1725 : added - close function to modal window.
c8d40e9 
 -
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
refs #1725 : added - close button.
17ad992 
 - TODO : Design for close button.
 - TODO : Add button on modify/delete view.
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
refs #1725 : added - close button on delete / modify pop-up (modal)
bd21f78 
 -
inureyes added a commit that referenced this issue Jan 18, 2015
@inureyes
closes #1725 : modified - prevent modal click to close.
f7b6501 
 -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inureyes inureyes

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@achimnol @inureyes @zvuc