Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken path for output_log #50

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fixed broken path for output_log #50

merged 1 commit into from
Apr 17, 2024

Conversation

diehy
Copy link
Contributor

@diehy diehy commented Jan 2, 2024

Being given the option for Doorstop to automatically redirect the output log is neat, and it saves me from running additional code to patch mainData for the redirect.

However, the path used for it is clearly incorrect, and I've noticed that it isn't just an issue for me: #39

After having a quick peek it appears that the wrong path variable is being used for the absolute directory path, resulting in it being trimmed early due to the filename length being short.

size_t app_dir_len = strlen(paths->doorstop_filename); // A simple goof!

A quick change resolves this issue:

size_t app_dir_len = strlen(paths->app_dir); // Yay it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants