Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build9 modifications #29

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Build9 modifications #29

merged 7 commits into from
Oct 5, 2023

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Oct 4, 2023

These are primarily bug-fixes related to SQLAlchemy table relations, but there are also some miscellaneous fixes.

Description

  • validators.validate_dateimte_asutc now properly raises a ValueError if the provided tz-aware datetime has a non-UTC tz offset (before any tz-aware datetime would pass the validator).
  • image_records.ImageRecord object now has pgaGain instead of ppaGain (which was surely a typo in the early upstream data.
  • create_image.py now correctly imports all of the tables that have a relation to the image_records table so that SQLAlchemy can properly resolve them, and downstream users of the create_image.create() function don't need to worry about sorting that out.
  • nss_simulator.py, when asked to produce an output set of maps, uses a zero nodata value rather than whatever nodata value was present in the input burial depth map.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (88bef16) 67.55% compared to head (12aa4fc) 67.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   67.55%   67.59%   +0.03%     
==========================================
  Files          44       44              
  Lines        2466     2472       +6     
==========================================
+ Hits         1666     1671       +5     
- Misses        800      801       +1     
Files Coverage Δ
src/vipersci/__init__.py 100.00% <100.00%> (ø)
src/vipersci/vis/anaglyph.py 98.59% <ø> (ø)
src/vipersci/vis/create_image.py 70.90% <100.00%> (+0.81%) ⬆️
src/vipersci/vis/db/image_records.py 90.53% <100.00%> (ø)
src/vipersci/vis/db/validators.py 95.23% <100.00%> (+0.50%) ⬆️
src/vipersci/carto/nss_simulator.py 56.25% <0.00%> (-0.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit 67a900f into main Oct 5, 2023
9 checks passed
@rbeyer rbeyer deleted the patches branch October 5, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant