Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightRecord changes #30

Merged
merged 13 commits into from
Oct 19, 2023
Merged

LightRecord changes #30

merged 13 commits into from
Oct 19, 2023

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Oct 14, 2023

This is primarily a conceptual change to the LightRecord object/table. Before, each row repesented an "on-span" but it has been changed to just record state changes, so a row indicates a light, a time, and which state was changed to (either "on" or "off").

yamcs_reception_time has been added to ImageRecord.

There are also some minor changes in PanoRecord that are not completely finished.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (86f3df7) 67.59% compared to head (81187e8) 67.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   67.59%   67.80%   +0.21%     
==========================================
  Files          44       44              
  Lines        2472     2479       +7     
==========================================
+ Hits         1671     1681      +10     
+ Misses        801      798       -3     
Files Coverage Δ
src/vipersci/vis/create_image.py 71.42% <100.00%> (+0.51%) ⬆️
src/vipersci/vis/db/create_vis_dbs.py 65.62% <100.00%> (+0.54%) ⬆️
src/vipersci/vis/db/image_records.py 90.63% <100.00%> (+0.10%) ⬆️
src/vipersci/vis/db/junc_image_pano.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/junc_image_req_ldst.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/light_records.py 100.00% <100.00%> (+10.34%) ⬆️
src/vipersci/vis/pds/create_raw.py 70.08% <100.00%> (+0.25%) ⬆️
src/vipersci/vis/db/pano_records.py 90.00% <81.81%> (+0.63%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit acb653e into main Oct 19, 2023
9 checks passed
@rbeyer rbeyer deleted the light_state branch October 19, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant