You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This might be nitpicking but I would like to point it out anyway. I believe that the name for the methods
AddClientRoleToUser
AddClientRoleToGroup
DeleteClientRoleFromUser
should be
AddClientRolesToUser
AddClientRolesToGroup
DeleteClientRolesFromUser
because they take as argument a slice of Role structs
Describe the solution you'd like
The change consists of using the plural in the name, like the method GetClientRolesByUserID
I'd be happy to fix it
Hope this was helpful. Thank you!
The text was updated successfully, but these errors were encountered:
Hi,
i understand that and agree, we can do this, but this will be a breaking change, so we'll only merge it, if we need to introduce other breaking changes :)
Is your feature request related to a problem? Please describe.
This might be nitpicking but I would like to point it out anyway. I believe that the name for the methods
AddClientRoleToUser
AddClientRoleToGroup
DeleteClientRoleFromUser
should be
AddClientRolesToUser
AddClientRolesToGroup
DeleteClientRolesFromUser
because they take as argument a slice of
Role
structsDescribe the solution you'd like
The change consists of using the plural in the name, like the method
GetClientRolesByUserID
I'd be happy to fix it
Hope this was helpful. Thank you!
The text was updated successfully, but these errors were encountered: