-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error refactoring #146
Error refactoring #146
Conversation
gnah xD |
this will most likely result in some merges as soon as i'm finished xD working through 1,4k lines of code :D |
Could be, just restore go.mod and go.sum |
I'm not quite sure, if we should also pack this if resp.StatusCode() == 409 {
return &ObjectAlreadyExists{ErrorMessage: msg}
} into an APIError as it feels like a specific error is better to handle 🤔 |
I think we should always return ApiError, we can easy check if status == 409 |
atleast we should treat these changes as breaking changes, when going up with the version, as the some integrations might check for specific error messages and/or the now removed error types. |
i'll try to fix the failing builds later |
sure |
Ok, I see. Please do something with: |
true, i'll have a look into it |
finally (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you
v5 released!!!! |
oh no |
need to remove v5 |
Wrap Errors and use APIError struct to also provide the httpstatus code.
Adresses: #132