Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added params for getting sessions associated with client #436

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

mopo3ula
Copy link
Contributor

Added params GetClientUserSessionsParams for GetClientUserSessions and GetClientOfflineSessions to match Keycloak API

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution.
That change would be a breaking change.

How do you feel about changes the parameters to variadic functions.
That would not break integrations and still provide the feature.

https://gobyexample.com/variadic-functions

@mopo3ula
Copy link
Contributor Author

@Nerzal made variadic functions and added tests to compare result with and without params

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #436 (e32f4b7) into main (166f442) will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   77.25%   77.26%   +0.01%     
==========================================
  Files           4        4              
  Lines        2198     2261      +63     
==========================================
+ Hits         1698     1747      +49     
- Misses        338      345       +7     
- Partials      162      169       +7     
Impacted Files Coverage Δ
client.go 75.82% <77.41%> (+0.04%) ⬆️
models.go 90.38% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mopo3ula mopo3ula requested a review from Nerzal July 17, 2023 12:29
@Nerzal Nerzal merged commit 7f490d9 into Nerzal:main Jul 25, 2023
@Nerzal
Copy link
Owner

Nerzal commented Jul 25, 2023

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants