Conditionally Setting Policies Endpoints #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keycloak server version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Keycloak versions >=
20.0.0. The endpoint to get/create/update the policies has been changed. It no longer includes the/policy-typepart.Similar to #286, I was facing this issue while running on Keycloak
v24.0.1and I couldn't use the policies endpoints.So this PR checks the server version and conditionally adds the
/policy-typepart or omits it. If the Keycloak version is>=20.0.0the part is omitted. In order to not hit the serverinfo endpoint everytime, I've added theversionfield toGocloak.Configso the API would only have to be called once.I've noticed that the tests on
mainare already failing so I haven't made any attempt to edit the test cases. Let me know if this will be a blocker. I've tested the policy fetching onv19.0.0v20.0.0,v24.0.0and it seems to work as intended in each one of these cases.