Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GetComponentParams ProviderType field to Type #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6610,7 +6610,7 @@
defer tearDown()
t.Log(createdClientID)
first := 0
max := 1

Check failure on line 6613 in client_test.go

View workflow job for this annotation

GitHub Actions / tests

redefines-builtin-id: redefinition of the built-in function max (revive)
// Looking for a created client
clients, err := client.GetClients(
context.Background(),
Expand Down Expand Up @@ -7027,9 +7027,9 @@
token.AccessToken,
cfg.GoCloak.Realm,
gocloak.GetComponentsParams{
Name: component.Name,
ProviderType: component.ProviderType,
ParentID: component.ParentID,
Name: component.Name,
Type: component.ProviderType,
ParentID: component.ParentID,
},
)
require.NoError(t, err, "GetComponentsWithParams failed")
Expand Down Expand Up @@ -7078,9 +7078,9 @@
token.AccessToken,
cfg.GoCloak.Realm,
gocloak.GetComponentsParams{
Name: component.Name,
ProviderType: component.ProviderType,
ParentID: component.ParentID,
Name: component.Name,
Type: component.ProviderType,
ParentID: component.ParentID,
},
)
require.NoError(t, err, "GetComponentWithParams after UpdateComponent failed")
Expand Down
6 changes: 3 additions & 3 deletions models.go
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,9 @@

// GetComponentsParams represents the optional parameters for getting components
type GetComponentsParams struct {
Name *string `json:"name,omitempty"`
ProviderType *string `json:"provider,omitempty"`
ParentID *string `json:"parent,omitempty"`
Name *string `json:"name,omitempty"`
Type *string `json:"type,omitempty"`
ParentID *string `json:"parent,omitempty"`
}

// ExecuteActionsEmail represents parameters for executing action emails
Expand Down Expand Up @@ -1426,7 +1426,7 @@
ProviderID *string `json:"providerId,omitempty"`
}

type UnregisteredRequiredActionProviderRepresentation struct {

Check failure on line 1429 in models.go

View workflow job for this annotation

GitHub Actions / tests

exported: exported type UnregisteredRequiredActionProviderRepresentation should have comment or be unexported (revive)
Name *string `json:"name,omitempty"`
ProviderID *string `json:"providerId,omitempty"`
}
Expand Down
Loading