Add provider for Verisign's managed DNS service #372
Conversation
|
NetflixOSS » denominator » denominator-pull-requests #142 FAILURE |
|
|
||
| @RunWith(Live.class) | ||
| @UseTestGraph(VerisignDnsTestGraph.class) | ||
| public class VerisignDnsTest { |
There was a problem hiding this comment.
this class seems to repeat work done in the normal live tests. also, it is storing XML, which seems distracting. Should this become a mock test? or should we remove it?
|
did a very cursory review. I might have an account to test with, still. Can do more review in a day or two. |
|
PS this looks much cleaner than before, nice work. Before we merge this, please review this and make sure qualifications are met. For example, we've not had any user ask for this. It may make sense to host this in your repository until there's diverse need, similar to how we support discoverydns. https://github.com/Netflix/denominator/wiki/Adding-new-Providers |
|
NetflixOSS » denominator » denominator-pull-requests #143 SUCCESS |
|
NetflixOSS » denominator » denominator-pull-requests #144 SUCCESS |
|
NetflixOSS » denominator » denominator-pull-requests #145 SUCCESS |
|
All, we tested the Denominator provider for Verisign’s managed DNS in our product and it worked fine. |
Please review this pull request, which implements a Denominator provider for Verisign’s managed DNS service. It includes basic zone and resource record management operations. It represents a substantial rewrite of previous submissions based on prior comments, and the new implementation is based on an existing provider implementation. Please let us know your feedback.