build: unbreak x86 builds #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE is not guaranteed to be present on x86 hosts, so i386..i686 compilers default to -mno-sse. That however makes the build fail because vmaf unconditionally uses emmintrin functions which are not available under no-sse. ppc64le builds however are just fine, so... Change the macro guarding emmintrin to not match on x86-like architectures, but to match on the enablement of SSE2. The macro "__SSE2__" is the gcc name and is true whenever -msse2 is enabled (explicitly or implicitly); clang should behave the same. I have not tested this under other compilers such as Microsoft, though. Fixes: #374
|
Merged. Ideally we could add a i386 CI runner to avoid breaking this in the future, but I'm not sure that is supported by our CI without self-hosting. |
|
I believe it's possible to do so by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSE is not guaranteed to be present on x86 hosts, so i386..i686
compilers default to -mno-sse. That however makes the build fail
because vmaf unconditionally uses emmintrin functions which are
not available under no-sse. ppc64le builds however are just fine, so...
Change the macro guarding emmintrin to not match on x86-like
architectures, but to match on the enablement of SSE2. The macro
"SSE2" is the gcc name and is true whenever -msse2 is enabled
(explicitly or implicitly); clang should behave the same. I have not
tested this under other compilers such as Microsoft, though.
Fixes: #374