Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PayloadId should be unique for each PayloadAttributes instance #5563

Closed
MarekM25 opened this issue Apr 13, 2023 · 1 comment · Fixed by #5587
Closed

PayloadId should be unique for each PayloadAttributes instance #5563

MarekM25 opened this issue Apr 13, 2023 · 1 comment · Fixed by #5587
Assignees
@rubo
Labels
bug stability

Comments

@MarekM25
Copy link
Contributor

ethereum/execution-apis#401
ethereum/pm#754 (comment)

Our PayloadId generation is not unique once only withdrawals are changed. It is a CL (Nimbus) bug, but it happened on besu<>nimbus so it might happen on Nethermind<>Nimbus as well. See the above links for more context
@LukaszRozmej
Copy link
Member

Let's move ComputeNextPayloadId method to be under PayloadAttributes class, so in the future we won't miss that.

@rubo rubo mentioned this issue Apr 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubo rubo

Labels
bug stability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include withdrawals in payload id computation NethermindEth/nethermind
3 participants
@rubo @MarekM25 @LukaszRozmej