Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include withdrawals in payload id computation #5587

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Include withdrawals in payload id computation #5587

merged 3 commits into from
Apr 18, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Apr 18, 2023 •
edited
Loading

Fixes #5563

Changes

  • Included withdrawals in payload id computation
  • Moved the PayloadPreparationService.ComputeNextPayloadId method to PayloadAttributesExtensions.ComputePayloadId

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Remarks

This PR adds withdrawals to payload id computation. The rest of the logic remains intact.

@rubo rubo requested review from MarekM25 and LukaszRozmej April 18, 2023 20:00
@rubo rubo force-pushed the feature/fcu-payload-id branch from e4b2f4b to 566a157 Compare April 18, 2023 20:03
@benaadams benaadams added the bug label Apr 18, 2023
@rubo rubo merged commit 4a3e9cf into master Apr 18, 2023
@rubo rubo deleted the feature/fcu-payload-id branch April 18, 2023 22:56
kamilchodola pushed a commit that referenced this pull request Apr 27, 2023
@rubo @kamilchodola
Include withdrawals in payload id computation (#5587)
3a5a5fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayloadId should be unique for each PayloadAttributes instance
3 participants
@rubo @LukaszRozmej @benaadams