Add Worldchain support #8044
Merged
Add Worldchain support #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jan 13, 2025
| @@ -355,6 +355,17 @@ private static void LoadAllocations(ChainSpecJson chainSpecJson, ChainSpec chain | |||
| return; | |||
| } | |||
|
|
|||
| Dictionary<Hash256, byte[]> codes = new(); | |||
There was a problem hiding this comment.
I think we don't need this dictionary and can just use chainSpecJson.CodeHashes directly later to conserve a bit of memory.
|
Do we want to add any auto pivot updates like in #8043? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Worldchain support
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes