Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/end to end synctest #8055

Merged
merged 37 commits into from
Jan 20, 2025
Merged

Feature/end to end synctest #8055

merged 37 commits into from
Jan 20, 2025

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jan 16, 2025

  • End to end sync tests.
    • Create a fullish nethermind server and client, connect them two and sync.
    • This is done in combination of (archive, hash, halpath) X (pre merge, post merge) X (full, fast, snap).
  • Cover as much as reasonable except for actualy IO and peer discovery, which includes block processing/production and snap/hash server and rlp encoding.
  • Replaces SyncThreadsTests.
  • Some bugfix will be spawn out to separate PR.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Well.. it passed.

@kamilchodola
Copy link
Contributor

@asdacap But we have sth like this (not in neth code but reproducing the result from here) - will send details on Slack

@asdacap
Copy link
Contributor Author

asdacap commented Jan 17, 2025

This is much smaller and not on a real network. Also, run on every PR.

@asdacap asdacap merged commit 50a6218 into master Jan 20, 2025
79 checks passed
@asdacap asdacap deleted the feature/end-to-end-synctest branch January 20, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants