Make sure prewarming and pruning trie store is running on ethereum tests #8076
Conversation
asdacap
force-pushed
the
feature/ensure-prewarming-is-running-en-ethereum-tests
branch
from
bfb5d8d to
ed58365
Compare
| @@ -104,6 +104,8 @@ public interface IWorldState : IJournal<Snapshot>, IReadOnlyStateProvider | |||
|
|
|||
| void DecrementNonce(Address address) => DecrementNonce(address, UInt256.One); | |||
|
|
|||
| void SetNonce(Address address, in UInt256 nonce); | |||
There was a problem hiding this comment.
This is not a normal use-case method when interacting with WorldState. Might be useful on some setups, but not sure if should be just public on interface.
There was a problem hiding this comment.
I'd say set it public. rbuilder need it and it'll make it easier to test paprika.
| IWorldState WorldState, | ||
| IBlockProcessor BlockProcessor, | ||
| ITransactionProcessor TransactionProcessor, |
There was a problem hiding this comment.
Added parameters are not used?
There was a problem hiding this comment.
Its used as a property.
| @@ -247,6 +204,13 @@ protected async Task<EthereumTestResult> RunTest(BlockchainTest test, Stopwatch? | |||
| await blockchainProcessor.StopAsync(true); | |||
| stopwatch?.Stop(); | |||
|
|
|||
| IBlockCachePreWarmer? preWarmer = container.Resolve<MainBlockProcessingContext>().LifetimeScope.ResolveOptional<IBlockCachePreWarmer>(); | |||
There was a problem hiding this comment.
Not sure if, but does this create any issue with parallel test invocation? If not can you be more specific about it? I think maybe LifetimeScope solves this but it isn't totally clear for me.
There was a problem hiding this comment.
It does not? Each invocation creates a completely different instance.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?