Set MaxAttemptsToUpdatePivot to -1 for infinite pivot update trials #8107
Conversation
| @@ -355,7 +355,7 @@ private bool ShouldBeInBeaconHeaders(bool shouldBeInUpdatingPivot) | |||
|
|
|||
| private bool ShouldBeInUpdatingPivot() | |||
| { | |||
| bool updateRequestedAndNotFinished = _syncConfig.MaxAttemptsToUpdatePivot > 0; | |||
| bool updateRequestedAndNotFinished = _syncConfig.MaxAttemptsToUpdatePivot == -1; | |||
There was a problem hiding this comment.
This logic needs to work not only with value of -1 - any value can be specified through config. With this logic, any positive value will most likely break syncing.
There was a problem hiding this comment.
Hi @damian-orzechowski , sorry I didn't consider the possibility of any value coming from the config, and the logic shall hold true given any value for MaxAttemptsToUpdatePivot from config. I have now updated the logic where retires happen infinite number of times if MaxAttemptsToUpdatePivot = -1 and finite number of times if MaxAttemptsToUpdatePivot = N, N being a positive number.
| @@ -873,7 +873,7 @@ public ScenarioBuilder WhenMergeSyncPivotNotResolvedYet() | |||
| _syncProgressSetups.Add( | |||
| () => | |||
| { | |||
| SyncConfig.MaxAttemptsToUpdatePivot = 3; | |||
| SyncConfig.MaxAttemptsToUpdatePivot = -1; | |||
There was a problem hiding this comment.
With tests, I'd be cautious to use any settings potentially causing infinite work
There was a problem hiding this comment.
I've reverted back the test to set MaxAttemptsToUpdatePivot = 3, so it can test by retrying pivot updates for exactly 3 number of times.
Fixes Closes Resolves #5992
Changes
ISyncConfig.csupdate the default value forMaxAttemptsToUpdatePivotto -1 in an attempt to make the pivot update trials to infinite instead of ~68 years_attemptsLeftnow begins with a value of -1 and keeps decrementing by 1,updated the condition in, handle its update conditionPivotUpdator.csMaxAttemptsToUpdatePivotchange to -1from positive, updated it in, handle both positive and negative value forMultiSyncModeSelector.csShouldBeInUpdatingPivotinMultiSyncModeSelector.csThereby updated its test case inMultiSyncModeSelectorTests.Scenario.csTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?