Fix blob tx size calculation #8123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are using incorrect blob tx sizes when announcing blob txs to our peers |
|
Hive tests |
LukaszRozmej
requested changes
Jan 29, 2025
Co-authored-by: Lukasz Rozmej <[email protected]>
LukaszRozmej
approved these changes
Jan 29, 2025
flcl42
reviewed
Jan 30, 2025
| @@ -197,7 +197,9 @@ private void ClearPreHashInternal() | |||
| /// </summary> | |||
| public int GetLength(ITransactionSizeCalculator sizeCalculator, bool shouldCountBlobs) | |||
There was a problem hiding this comment.
Might be cool in addition to Transaction to have NetworkTransaction class-wrapper with GetTransaction method or so to make it clearer which form is used here or there. So you can't call GetLength for transaction without NetworkWrapper. May be too much work though
flcl42
approved these changes
Jan 30, 2025
brbrr
pushed a commit
that referenced
this pull request
Jan 30, 2025
Co-authored-by: Lukasz Rozmej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8121
Changes
When adding filter for max tx size (#7925) I introduced a regression. In
SizeTxFilterwe are calculating sizes of blob txs without including blobs. The value is saved, so we are not recalculating it later, when we need size of the whole tx, including blobs.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Hive tests were failing because of regression, it is fixed now
Documentation
Requires documentation update
Requires explanation in Release Notes