JsonRpc standardization: change MinerPremiumNegative error to FeeCapTooLow

[yerke26]

Currently eth_call, eth_simulateV1, eth_estimateGas, eth_sendRawTransaction, eth_sendTransaction returns in Geth and Nethermind different error message for the same error:

Geth link to code:

{
    "jsonrpc": "2.0",
    "id": 1,
    "error": {
        "code": -32000,
        "message": "err: max fee per gas less than block base fee: address 0xD3b2Bd4b38360057644C60b1ae7a568D219525b4, maxFeePerGas: 0, baseFee: 0 (supplied gas 50000000)"
    }
}

Nethermind:

{
    "jsonrpc": "2.0",
    "error": {
        "code": -32000,
        "message": "miner premium is negative"
    },
    "id": 1
}

Changes

• replaced MinerPremiumNegative with FeeCapTooLow

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

[yerke26]

should change MINER_PREMIUM_IS_NEGATIVE log also?

[alexb5dh]

Does geth show same "max fee per gas less than block base fee..." error message in logs?

[yerke26]

yes, it is:
WARN [02-03|17:35:21.985] Served eth_call conn=127.0.0.1:51596 reqid=1 duration="395.958µs" err="err: max fee per gas less than block base fee: address 0x32E4E4c7c5d1CEa5db5F9202a9E4D99E56c91a24, maxFeePerGas: 0, baseFee: 0 (supplied gas 50000000)"

[alexb5dh]

My suggestion would be to log the same or similar message

[yerke26]

should change MINER_PREMIUM_IS_NEGATIVE log also?

[MarekM25]

yes, we can change it

[MarekM25]

Think about covering by test

[MarekM25]

yes, we can change it