Proper Transaction type for eth_* calls when running Optimism

[emlautarom1]

Changes

• Properly map Transaction type instead of always using 0x7E ("deposit")

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Added unit tests to ensure that we're not changing TxType and we're including additional receipt information for "deposit" transactions only.

Documentation

Requires documentation update

• Yes
• No

Requires explanation in Release Notes

• Yes
• No

Remarks

I'm curious as to why we didn't get this reported earlier considering that the issue has been present since #7483.

[emlautarom1]

Are all receipts always of type OptimismTxReceipt or is it possible to have a TxReceipt? If the later is correct then this cast will fail at runtime.

cc. @flcl42 @jmederosalvarado

[LukaszRozmej]

Potentially you could make EthRpcModule bit more extensible and avoid some code duplication.

[emlautarom1]

Potentially you could make EthRpcModule bit more extensible and avoid some code duplication.

I've removed the duplication in the eth_getTransactionByBlock[Hash|Number]AndIndex by merging both into a single method, thus requiring a single override rather than two.