Fix state override accessing state #8168
Open
+37
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
requested review from
alexb5dh,
asdacap and
kamilchodola
and removed request for
alexb5dh
alexb5dh
approved these changes
Feb 5, 2025
src/Nethermind/Nethermind.Consensus/Processing/OverridableTxProcessingScope.cs
Show resolved
Hide resolved
asdacap
approved these changes
Feb 5, 2025
benaadams
approved these changes
Feb 5, 2025
alexb5dh
reviewed
Feb 5, 2025
| @@ -125,6 +122,7 @@ public GethLikeTxTrace Trace(Hash256 blockHash, int txIndex, GethTraceOptions op | |||
| if (tx.Hash is null) throw new InvalidOperationException("Cannot trace transactions without tx hash set."); | |||
|
|
|||
| block = block.WithReplacedBodyCloned(BlockBody.WithOneTransactionOnly(tx)); | |||
| using IOverridableTxProcessingScope? scope = _env.BuildAndOverride(block.Header, options.StateOverrides); | |||
There was a problem hiding this comment.
I don't think scope needs to be nullable here and in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8130 and #7945
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
eth_call/eth_estimateGas/eth_simulate/debug_traceXXX/trace_fuzzing with state overrides