Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TryCalculateFeePerBlobGas #8173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize TryCalculateFeePerBlobGas #8173

wants to merge 1 commit into from
+13 −8

Conversation

benaadams
Copy link
Member

Changes

  • Skip expensive 256bit multiplication when factor is 1 (which it is currently)
  • Use ulong iterator rather than UInt256 iterator which has much more expensive increments
  • Use .IsZero rather than > 0 which is faster as it just vector checks everything is 0

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@yerke26 yerke26 Awaiting requested review from yerke26

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benaadams