fix(ica): add controller stack

[k-yang]

Purpose / Abstract

Add ICA controller stack to Nibiru Chain. See https://github.com/CosmWasm/wasmd/blob/main/app/app.go#L655-L669 for a reference implementation.

Relates to #1820.

[coderabbitai]

Warning

Rate Limit Exceeded

@k-yang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 29 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4d3205a and 9c05c45.

Walkthrough

The recent updates to the NibiruChain/nibiru repository enhance interchain functionalities and improve Ethereum compatibility. Key enhancements include the addition of interchain accounts, fixes to the ICA controller stack, and updates to the Ethereum RPC backend, tracer, KV indexer, and RPC APIs.

Changes

File Path	Change Summary
CHANGELOG.md	Added interchain accounts, fixed ICA controller stack, updated Ethereum RPC components.
app/keepers.go	Integrated new IBC middleware and modules for interchain accounts.

Poem

🐇💻
In the land of code, where the nibiru lays,
New changes bloom, like the sun's first rays.
Interchain accounts, now join the fray,
Fixing, mixing in the blockchain ballet.
Hopping through code, with a carrot daydream,
A rabbit’s work, stitching the digital seam.
🌟🚀🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 83da4ad and 4f94db8.

Files selected for processing (2)

• CHANGELOG.md (2 hunks)
• app/keepers.go (2 hunks)

Additional Context Used

GitHub Check Runs (1)

lint failure (2)

app/keepers.go: [failure] 544-544:
S1021: should merge variable declaration with assignment on next line (gosimple)

Additional comments not posted (1)

app/keepers.go (1)

545-545: ICA Host Stack setup looks good.

[coderabbitai]

Merge variable declaration with assignment.

- var noAuthzModule porttypes.IBCModule
- icaControllerStack = icacontroller.NewIBCMiddleware(noAuthzModule, app.icaControllerKeeper)
+ icaControllerStack = icacontroller.NewIBCMiddleware(porttypes.IBCModule{}, app.icaControllerKeeper)

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	var noAuthzModule porttypes.IBCModule
	icaControllerStack = icacontroller.NewIBCMiddleware(noAuthzModule, app.icaControllerKeeper)
	icaControllerStack = icacontroller.NewIBCMiddleware(porttypes.IBCModule{}, app.icaControllerKeeper)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (83da4ad) to head (9c05c45).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   67.84%   67.85%   +0.01%     
==========================================
  Files         203      203              
  Lines       13064    13070       +6     
==========================================
+ Hits         8863     8869       +6     
  Misses       3561     3561              
  Partials      640      640              

Files	Coverage Δ
app/keepers.go	99.13% <100.00%> (+0.01%)	⬆️

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f94db8 and 4d3205a.

Files selected for processing (1)

• app/keepers.go (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/keepers.go