Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make default db backend PebbleDB #1908

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jun 4, 2024

Purpose / Abstract

Makes PebbleDB the default DB Backend. It doesn't affect existing nodes. It only sets db_backend = "pebbledb" in config.toml when nibid init is called.

Summary by CodeRabbit

  • New Features
    • Updated the default database backend to pebbledb for improved performance and reliability.

Copy link
Contributor

coderabbitai bot commented Jun 4, 2024

Walkthrough

The recent changes to the Nibiru project involve updating the default database backend to pebbledb. This update includes modifying the database backend assignment in the configuration initialization file and reflecting this change in the project's changelog. The primary goal is to enhance database configuration options by supporting pebbledb.

Changes

File Change Summary
CHANGELOG.md Added an entry for making pebbledb the default database backend.
cmd/nibid/cmd/init.go Updated the customTendermintConfig function to set DBBackend to pebbledb.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Add pebbledb support (1818)

Poem

In the land of code, where changes flow,
PebbleDB now takes the show.
RocksDB steps aside, with grace,
A new backend now in place.
Nibiru shines with database might,
Configured to scale, day and night.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@k-yang k-yang marked this pull request as ready for review June 4, 2024 15:35
@k-yang k-yang requested a review from a team as a code owner June 4, 2024 15:35
@k-yang k-yang self-assigned this Jun 4, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3a60458 and ebcbf4e.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • cmd/nibid/cmd/init.go (1 hunks)
Additional comments not posted (2)
cmd/nibid/cmd/init.go (1)

56-56: Change to use PebbleDBBackend as the default database backend is correctly implemented.

Verification successful

The change to use PebbleDBBackend as the default database backend is correctly implemented and does not affect other parts of the system.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the rest of the system is compatible with `PebbleDBBackend`.

# Test: Search for any hardcoded references to the old `RocksDBBackend`.
rg --type go $'RocksDBBackend'

Length of output: 29



Script:

#!/bin/bash
# Description: Verify that the rest of the system is compatible with `PebbleDBBackend`.

# Test 1: Search for any references to `RocksDBBackend` in all file types.
rg 'RocksDBBackend'

# Test 2: Search for any specific configurations or initializations related to database backends.
rg 'db\.RocksDBBackend'

Length of output: 45



Script:

#!/bin/bash
# Description: Verify that the rest of the system is compatible with `PebbleDBBackend`.

# Test 1: Search for any references to `RocksDBBackend` in documentation files.
rg 'RocksDBBackend' --glob '*.md'

# Test 2: Search for any references to `RocksDBBackend` in test files.
rg 'RocksDBBackend' --glob '*_test.go'

Length of output: 72

CHANGELOG.md (1)

52-52: The changelog entry for making PebbleDB the default database backend is correctly formatted and placed. Good job maintaining the project's documentation standards.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.34%. Comparing base (bbcc6f8) to head (aba683e).
Report is 1 commits behind head on main.

Current head aba683e differs from pull request most recent head 189d0de

Please upload reports for the commit 189d0de to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1908   +/-   ##
=======================================
  Coverage   62.34%   62.34%           
=======================================
  Files         245      245           
  Lines       15949    15949           
=======================================
  Hits         9944     9944           
  Misses       5269     5269           
  Partials      736      736           
Files Coverage Δ
cmd/nibid/cmd/init.go 25.74% <100.00%> (ø)

@k-yang k-yang enabled auto-merge (squash) June 4, 2024 15:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ebcbf4e and aba683e.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@Unique-Divine Unique-Divine disabled auto-merge June 6, 2024 00:31
@Unique-Divine Unique-Divine enabled auto-merge (squash) June 6, 2024 00:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aba683e and 189d0de.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@Unique-Divine Unique-Divine merged commit 70ee1bf into main Jun 6, 2024
14 checks passed
@Unique-Divine Unique-Divine deleted the chore/db/default-pebbledb branch June 6, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

2 participants