-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make default db backend PebbleDB #1908
Conversation
WalkthroughThe recent changes to the Nibiru project involve updating the default database backend to Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- cmd/nibid/cmd/init.go (1 hunks)
Additional comments not posted (2)
cmd/nibid/cmd/init.go (1)
56-56
: Change to usePebbleDBBackend
as the default database backend is correctly implemented.Verification successful
The change to use
PebbleDBBackend
as the default database backend is correctly implemented and does not affect other parts of the system.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the rest of the system is compatible with `PebbleDBBackend`. # Test: Search for any hardcoded references to the old `RocksDBBackend`. rg --type go $'RocksDBBackend'Length of output: 29
Script:
#!/bin/bash # Description: Verify that the rest of the system is compatible with `PebbleDBBackend`. # Test 1: Search for any references to `RocksDBBackend` in all file types. rg 'RocksDBBackend' # Test 2: Search for any specific configurations or initializations related to database backends. rg 'db\.RocksDBBackend'Length of output: 45
Script:
#!/bin/bash # Description: Verify that the rest of the system is compatible with `PebbleDBBackend`. # Test 1: Search for any references to `RocksDBBackend` in documentation files. rg 'RocksDBBackend' --glob '*.md' # Test 2: Search for any references to `RocksDBBackend` in test files. rg 'RocksDBBackend' --glob '*_test.go'Length of output: 72
CHANGELOG.md (1)
52-52
: The changelog entry for making PebbleDB the default database backend is correctly formatted and placed. Good job maintaining the project's documentation standards.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
=======================================
Coverage 62.34% 62.34%
=======================================
Files 245 245
Lines 15949 15949
=======================================
Hits 9944 9944
Misses 5269 5269
Partials 736 736
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Purpose / Abstract
Makes
PebbleDB
the default DB Backend. It doesn't affect existing nodes. It only setsdb_backend = "pebbledb"
inconfig.toml
whennibid init
is called.Summary by CodeRabbit
pebbledb
for improved performance and reliability.