Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): 1. Generated smart contract types for ethers. 2. TypeScript support. 3. Formatter #1917

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Jun 8, 2024

Purpose

  1. TypeScript, etc. - test(e2e): (1) Generated smart contract types for ethers. (2) TypeScript support. (3) Formatter
  2. When we run the E2E tests, they're more nondeterministic than I'd like. - The goal here is to make the test runs even more consistent and account for problems like sequence mismatches where the tests collide by broadcasting transactions at the same time.

commit 021d161d176112cf24e28780ad64f61155f70ea2
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 22:00:10 2024 -0500

    test(e2e): (1) Generated smart contract types for ethers. (2) TypeScript support. (3) Formatter

commit af7e7b3
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 16:11:45 2024 -0500

    chore: another issue ticket

commit 36745fd
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 16:07:20 2024 -0500

    chore: add issue number for TODO comment

commit 8a76c0e
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 15:54:07 2024 -0500

    refactor(evm): Remove dead code and document non-EVM ante handler

commit e4e11df
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 15:52:38 2024 -0500

    refactor: remove dead code

commit cad00c0
Merge: dc5f4dd 359e310
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 15:41:53 2024 -0500

    Merge branch 'main' into ud/ante-test

commit dc5f4dd
Author: Unique-Divine <[email protected]>
Date:   Fri Jun 7 15:28:53 2024 -0500

    refactor: ante handler and evm cleanup

commit f73cdc3
Merge: d3a6ea9 290c372
Author: Unique-Divine <[email protected]>
Date:   Wed Jun 5 20:59:39 2024 -0500

    Merge branch 'test/evm-grpc-query' of https://github.com/NibiruChain/nibiru into test/evm-grpc-query

commit d3a6ea9
Merge: 376596d 70ee1bf
Author: Unique-Divine <[email protected]>
Date:   Wed Jun 5 20:59:30 2024 -0500

    Merge branch 'main' into test/evm-grpc-query

commit 376596d
Author: Unique-Divine <[email protected]>
Date:   Wed Jun 5 20:58:40 2024 -0500

    Squashed commit of the following:

    commit b5687130ff5f3d020a3b14d219fec3a816579c30
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 20:57:44 2024 -0500

        chore: run tidy

    commit 1f1f938
    Merge: 3e3cc83 bbcc6f8
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 19:16:30 2024 -0500

        Merge branch 'main' into ud/fix-race-condition

    commit 3e3cc83
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 19:15:40 2024 -0500

        chore: changelog

    commit 3876ccb
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 19:04:00 2024 -0500

        refactor: more consistent test names

    commit aaa0a19
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 18:53:09 2024 -0500

        test(oracle): Fix missing tear down step for oracle integration test

    commit 8c3c35e
    Author: Unique-Divine <[email protected]>
    Date:   Wed Jun 5 17:55:56 2024 -0500

        chore: add test comands to justfile

    commit 4916282
    Merge: 64ed0a2 e7e708d
    Author: Unique-Divine <[email protected]>
    Date:   Fri May 31 09:35:33 2024 -0500

        Merge branch 'main' into ud/fix-race-condition

    commit 64ed0a2
    Author: Unique-Divine <[email protected]>
    Date:   Fri May 31 01:44:55 2024 -0500

        fix(gosdk): tests parallel race condition

commit 290c372
Merge: 0d1c894 70ee1bf
Author: Unique Divine <[email protected]>
Date:   Wed Jun 5 20:05:19 2024 -0500

    Merge branch 'main' into test/evm-grpc-query

commit 0d1c894
Merge: 9170835 ad173e9
Author: Unique Divine <[email protected]>
Date:   Wed Jun 5 19:34:38 2024 -0500

    Merge branch 'main' into test/evm-grpc-query

commit 9170835
Author: Oleg Nikonychev <[email protected]>
Date:   Wed Jun 5 13:55:14 2024 +0400

    fix: removed hardcoded gas value in grpc_query test

commit 4337858
Author: Oleg Nikonychev <[email protected]>
Date:   Wed Jun 5 13:14:34 2024 +0400

    chore: refactored eth util methods

commit 7df84e2
Merge: 8918498 bbcc6f8
Author: Oleg Nikonychev <[email protected]>
Date:   Wed Jun 5 12:23:51 2024 +0400

    chore: resolve conflicts

commit 8918498
Merge: 3fd45ce e7e708d
Author: Oleg Nikonychev <[email protected]>
Date:   Mon Jun 3 21:56:39 2024 +0400

    Merge branch 'main' into test/evm-grpc-query

commit 3fd45ce
Author: Oleg Nikonychev <[email protected]>
Date:   Mon Jun 3 21:56:23 2024 +0400

    chore: changelog update

commit 3348876
Author: Oleg Nikonychev <[email protected]>
Date:   Mon Jun 3 21:53:54 2024 +0400

    test(evm): grpc_query full coverage
Copy link
Contributor

coderabbitai bot commented Jun 8, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits

Files that changed from the base of the PR and between f88a395 and 6729b97.

Files ignored due to path filters (1)
  • e2e/evm/package-lock.json is excluded by !**/package-lock.json
Files selected for processing (24)
  • .github/workflows/e2e-evm.yml (2 hunks)
  • .gitignore (1 hunks)
  • CHANGELOG.md (1 hunks)
  • e2e/evm/.nvmrc (1 hunks)
  • e2e/evm/justfile (1 hunks)
  • e2e/evm/package.json (1 hunks)
  • e2e/evm/prettier.config.mjs (1 hunks)
  • e2e/evm/test/basic_queries.test.ts (1 hunks)
  • e2e/evm/test/contract_infinite_loop_gas.test.ts (1 hunks)
  • e2e/evm/test/contract_send_nibi.test.ts (1 hunks)
  • e2e/evm/test/erc20.test.ts (1 hunks)
  • e2e/evm/test/setup.ts (1 hunks)
  • e2e/evm/tsconfig.json (1 hunks)
  • e2e/evm/types/ethers-contracts/FunTokenCompiled.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/InfiniteLoopGasCompiled.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/ReceiveNibiCompiled.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/SendNibiCompiled.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/common.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/factories/FunTokenCompiled__factory.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/factories/InfiniteLoopGasCompiled__factory.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/factories/ReceiveNibiCompiled__factory.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/factories/SendNibiCompiled__factory.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/factories/index.ts (1 hunks)
  • e2e/evm/types/ethers-contracts/index.ts (1 hunks)
 __________________________________________________________
< Solving problems you didn't know you were about to have. >
 ----------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Unique-Divine Unique-Divine changed the title test(e2e): (1) Generated smart contract types for ethers. (2) TypeScript support. (3) Formatter test(e2e): 1. Generated smart contract types for ethers. 2. TypeScript support. 3. Formatter Jun 8, 2024
@Unique-Divine Unique-Divine marked this pull request as ready for review June 10, 2024 09:06
@Unique-Divine Unique-Divine requested a review from a team as a code owner June 10, 2024 09:06
@Unique-Divine Unique-Divine merged commit 42a8b65 into main Jun 10, 2024
11 checks passed
@Unique-Divine Unique-Divine deleted the ud/e2e-evm-ts branch June 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant