refactor(localnet): preserve local keyring on make localnet

[k-yang]

Purpose / Abstract

A really annoying thing about the make localnet script is that it destroys the local keyring on every invocation. It makes interacting with other networks (e.g. mainnet, testnet, and devnet) really annoying.

This PR fixes the localnet.sh script to preserve the local keyring and only delete the local data files, so that localnet starts fresh from block 1.

Summary by CodeRabbit

• Chores
  • Updated script flag FLAG_NO_BUILD to FLAG_SKIP_BUILD for better clarity.
  • Improved flag logic and data removal steps in the localnet.sh script.

[coderabbitai]

Warning

Rate limit exceeded

@k-yang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0064fca and 6089b79.

Walkthrough

The script localnet.sh was updated to rename the flag FLAG_NO_BUILD to FLAG_SKIP_BUILD. This change enhances clarity by more accurately reflecting the flag's purpose, which is to control whether the build process should be skipped. Additionally, related flag logic and output messages were adjusted to align with the new flag name.

Changes

File	Change Summary
contrib/scripts/localnet.sh	Renamed FLAG_NO_BUILD to FLAG_SKIP_BUILD, updated flag logic, and adjusted output messages.

Poem

In the land of scripts, there’s a tale to unfold,
A flag’s name changed, a story to be told.
From NO_BUILD to SKIP, it found its true fit,
Now clearer, more accurate, I must admit.
Code evolves, with steps so bold,
Embracing the new, while honoring the old.
🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 822d838 and c8f5b25.

Files selected for processing (1)

• contrib/scripts/localnet.sh (6 hunks)

Additional comments not posted (5)

contrib/scripts/localnet.sh (5)

57-59: LGTM! The flag renaming improves clarity.

The comment correctly describes the behavior of the FLAG_SKIP_BUILD flag.

---

84-84: LGTM! The flag renaming ensures consistency.

The --no-build flag has been renamed to --skip-build to match the updated flag name.

---

99-100: LGTM! The flag check is consistent with the renaming.

The script checks the FLAG_SKIP_BUILD flag to determine whether to build from source.

---

105-105: LGTM! The debug output matches the updated flag name.

The script prints the value of the FLAG_SKIP_BUILD flag for debugging purposes.

---

122-126: LGTM! The script preserves the keyring and config files.

The change ensures that the keyring is preserved while removing previous chain data, which is crucial for interactions with other networks.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c8f5b25 and 0064fca.

Files selected for processing (1)

• contrib/scripts/localnet.sh (7 hunks)

Files skipped from review as they are similar to previous changes (1)

• contrib/scripts/localnet.sh