chore(evm): wiped deprecated evm apis: miner, personal #1958
Conversation
WalkthroughThe changes primarily focus on eliminating deprecated and unused Ethereum JSON-RPC APIs and Proof of Work (PoW) functionalities. This involves removing several methods related to miner operations and personal account management from various backend components and refactoring test cases. This cleanup reflects a shift towards post-merge Ethereum (Proof of Stake) and modernizing the codebase by discarding outdated APIs and practices. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
+ Coverage 64.83% 65.32% +0.48%
==========================================
Files 253 251 -2
Lines 16065 15790 -275
==========================================
- Hits 10416 10315 -101
+ Misses 4892 4729 -163
+ Partials 757 746 -11
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- CHANGELOG.md (1 hunks)
- app/server/config/server_config.go (1 hunks)
- eth/rpc/backend/backend.go (1 hunks)
- eth/rpc/backend/node_info.go (3 hunks)
- eth/rpc/backend/node_info_test.go (3 hunks)
- eth/rpc/rpcapi/apis.go (2 hunks)
Files skipped from review due to trivial changes (2)
- app/server/config/server_config.go
- eth/rpc/backend/backend.go
Additional comments not posted (6)
eth/rpc/rpcapi/apis.go (3)
29-38: LGTM! Initialization ofNamespaceEthis correct.The initialization of
NamespaceEthwithNewImplEthAPIandfiltersapi.NewImplFiltersAPIlooks correct.
Line range hint
39-47: LGTM! Initialization ofNamespacePersonalis correct.The initialization of
NamespacePersonalwithNewImplPersonalAPIlooks correct.
Line range hint
48-56: LGTM! Initialization ofNamespaceDebugis correct.The initialization of
NamespaceDebugwithdebugapi.NewImplDebugAPIlooks correct.eth/rpc/backend/node_info_test.go (2)
Line range hint
26-43: LGTM! Modifications toTestListAccountsare correct.The modifications to
TestListAccountsto include logic related to setting gas prices and etherbase addresses look correct.
Line range hint
48-73: LGTM! Modifications toTestSyncingare correct.The modifications to
TestSyncingto incorporate related functionality from removed tests look correct.CHANGELOG.md (1)
79-79: LGTM!The change is correctly documented in the "State Machine Breaking" section.
onikonychev
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- CHANGELOG.md (1 hunks)
- app/server/config/server_config.go (2 hunks)
- eth/rpc/backend/backend.go (3 hunks)
- eth/rpc/backend/chain_info.go (1 hunks)
- eth/rpc/backend/chain_info_test.go (1 hunks)
- eth/rpc/backend/node_info.go (2 hunks)
- eth/rpc/backend/node_info_test.go (3 hunks)
- eth/rpc/rpcapi/apis.go (3 hunks)
- eth/rpc/rpcapi/eth_api.go (4 hunks)
- x/evm/keeper/msg_server.go (1 hunks)
Files skipped from review due to trivial changes (2)
- eth/rpc/backend/chain_info_test.go
- x/evm/keeper/msg_server.go
Files skipped from review as they are similar to previous changes (5)
- CHANGELOG.md
- app/server/config/server_config.go
- eth/rpc/backend/backend.go
- eth/rpc/backend/node_info.go
- eth/rpc/rpcapi/apis.go
Additional comments not posted (17)
eth/rpc/backend/node_info_test.go (3)
Line range hint
8-33:
LGTM!The test cases for
TestRPCMinGasPriceare well-structured and cover the expected scenarios.
Line range hint
35-54:
LGTM!The test case for
TestAccountsis well-structured and covers the expected scenario.
Line range hint
56-101:
LGTM!The test cases for
TestSyncingare well-structured and cover the expected scenarios.eth/rpc/backend/chain_info.go (6)
Line range hint
14-26:
LGTM!The
ChainIDfunction logic is correct and handles errors appropriately.
Line range hint
28-36:
LGTM!The
ChainConfigfunction logic is correct and handles errors appropriately.
Line range hint
38-50:
LGTM!The
BaseFeefunction logic is correct and handles errors appropriately.
Line range hint
52-56:
LGTM!The
CurrentHeaderfunction logic is correct and handles errors appropriately.
Line range hint
58-76:
LGTM!The
PendingTransactionsfunction logic is correct and handles errors appropriately.
Line range hint
78-149:
LGTM!The
FeeHistoryfunction logic is correct and handles errors appropriately. It is a new addition to the file.eth/rpc/rpcapi/eth_api.go (8)
Line range hint
34-51:
LGTM!The functions
BlockNumber,GetBlockByNumber, andGetBlockByHashare well-structured and handle errors appropriately.
Line range hint
53-83:
LGTM!The functions related to reading transactions are well-structured and handle errors appropriately.
Line range hint
85-95:
LGTM!The functions related to writing transactions are well-structured and handle errors appropriately.
Line range hint
97-128:
LGTM!The functions related to account information are well-structured and handle errors appropriately.
Line range hint
130-142:
LGTM!The
Callfunction is well-structured and handles errors appropriately.
Line range hint
144-176:
LGTM!The functions related to chain information are well-structured and handle errors appropriately.
Line range hint
178-198:
LGTM!The functions related to uncles are well-structured and handle errors appropriately.
Line range hint
200-298:
LGTM!The other functions are well-structured and handle errors appropriately.
Summary by CodeRabbit
New Features
FeeHistoryfunction for fee estimation based on block range.Refactor
minerandpersonal.SetEtherbase,SetGasPrice, andCoinbase.Tests
Chores