chore(evm): remove ExtensionOptionsWeb3Tx and ExtensionOptionDynamicFeeTx #1983
Conversation
WalkthroughThe recent changes involve updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
eth/codec_test.go (1)
Inconsistency Found: The reference to
TxExtensionOptionIinx/evm/codec.gocontradicts the removal of the test case related tocosmos.tx.v1beta1.TxExtensionOptionI. To maintain consistency, this reference should also be removed.
- File:
x/evm/codec.go- Line: Reference to
(*tx.TxExtensionOptionI)(nil)Please remove this reference to ensure the complete deprecation of
TxExtensionOptionI.Analysis chain
Line range hint
36-63:
Verify removal of the test case.The removal of the test case related to
cosmos.tx.v1beta1.TxExtensionOptionIseems to align with the PR objective of removing legacy transaction extension options. Ensure that this change does not affect other parts of the test suite or the functionality of the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the removal of the test case does not affect other parts of the test suite or the functionality of the codebase. # Test: Search for any remaining references to `cosmos.tx.v1beta1.TxExtensionOptionI`. Expect: No occurrences. rg --type go 'cosmos.tx.v1beta1.TxExtensionOptionI'Length of output: 51
Script:
#!/bin/bash # Description: Verify that the removal of the test case does not affect other parts of the test suite or the functionality of the codebase. # Search for any remaining references to `TxExtensionOptionI` to ensure no related dependencies are missed. rg --type go 'TxExtensionOptionI' # Search for any remaining references to `cosmos.tx.v1beta1` to ensure no related dependencies are missed. rg --type go 'cosmos.tx.v1beta1'Length of output: 114
Script:
#!/bin/bash # Description: Review the context around the reference to `TxExtensionOptionI` in `x/evm/codec.go`. # Display the lines around the reference to `TxExtensionOptionI` in `x/evm/codec.go`. rg --type go 'TxExtensionOptionI' -A 5 -B 5Length of output: 525
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
eth/dynamic_fee.pb.gois excluded by!**/*.pb.goeth/web3.pb.gois excluded by!**/*.pb.go
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- eth/codec.go (3 hunks)
- eth/codec_test.go (1 hunks)
Files skipped from review due to trivial changes (2)
- CHANGELOG.md
- eth/codec.go
Purpose / Abstract
Removes
ExtensionOptionsWeb3TxandExtensionOptionDynamicFeeTx. These are legacy tx extension options from Ethermint that are not valid for Nibiru Chain.Summary by CodeRabbit
Chores
Tests