-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enabled grpc for localnet #1992
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent updates enhance the Nibiru blockchain's networking capabilities by enabling gRPC for local development. This change, part of a larger overhaul, includes migrating the Go SDK and updating dependencies. The modifications facilitate better communication protocols within the local environment, ensuring developers can leverage the latest tools for efficient blockchain development. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- contrib/scripts/localnet.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
Additional context used
Shellcheck
contrib/scripts/localnet.sh
[warning] 158-158: Quotes/backslashes in this variable will not be respected.
(SC2090)
@@ -153,6 +153,11 @@ $BINARY config # Prints config. | |||
echo_info "config/app.toml: Enabling API server" | |||
sed -i $SEDOPTION '/\[api\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml | |||
|
|||
# Enable GRPC Server | |||
echo_info "config/app.toml: Enabling GRPC server" | |||
sed -i $SEDOPTION '/\[grpc\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote the SEDOPTION variable in the sed command.
The SEDOPTION
variable should be quoted to prevent issues if it contains spaces or special characters.
- sed -i $SEDOPTION '/\[grpc\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml
+ sed -i "$SEDOPTION" '/\[grpc\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
sed -i $SEDOPTION '/\[grpc\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml | |
sed -i "$SEDOPTION" '/\[grpc\]/,+3 s/enable = false/enable = true/' $CHAIN_DIR/config/app.toml |
Tools
Shellcheck
[warning] 158-158: Quotes/backslashes in this variable will not be respected.
(SC2090)
Summary by CodeRabbit
New Features
Documentation