-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Python tooling #36
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed the ticket yesterday so I had something to work on today :(
This change is doing WAY too much all at once; the intention of the ticket was to only replace setup.py with pyproject.toml, and switch the build system to hatchling and setuptools_scm. I specifically did not want to remove tox (yet) nor change linters, the publisher action, or anything like that. (Side note: you have not updated any documentation.)
It's not really that much change, it just looks like it. The Most of what looks like churn is simply copy+paste of discrete config files into the corresponding The linter changes are similarly low-effort; my original approach was to drop in Ruff with a giant stack of ignores, and promise to peel them back later. I can do that instead, if it makes things easier. |
Downsized for the sake of sanity. |
Move all configs into `pyproject.toml`, switch test/packaging to use Hatch, and do all the linting with Ruff. Fix issues that Ruff turned up, and annotate/ignore the pieces that it got wrong. Fixes: Issue NicolasLM#33
Generate the documentation with `hatch run docs:build $TYPE`
Move all configs into
pyproject.toml
, switch test/packaging to use Hatch, and do all the linting with Ruff.Fix issues that Ruff turned up, and annotate/ignore the pieces that it got wrong.
Fixes: Issue #33