RedisBroker: Track non-idempotent jobs as running, too #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push running-job markers down into the Redis for all jobs, and move the logic for re-enqueueing jobs from dead brokers into the script itself. Non-idempotent jobs running on a dead broker are still NOT re-enqueued. This should cause non-idempotent jobs to no longer run "invisibly" on a Redis broker, as well as causing dead brokers to signal any non-idempotent jobs that were running on them as failed. Fixes: Issue NicolasLM#18
|
Got hit by this one today when that worker got killed! |
bigjools
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push running-job markers down into the Redis for all jobs, and move the logic for re-enqueueing jobs from dead brokers into the script itself. Non-idempotent jobs running on a dead broker are still NOT re-enqueued.
This should cause non-idempotent jobs to no longer run "invisibly" on a Redis broker, as well as causing dead brokers to signal any non-idempotent jobs that were running on them as failed.
Fixes: Issue #18