Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dhalang doesn't work on Windows #55

Open
NielsSteensma opened this issue Jul 27, 2024 · 0 comments
Open

Dhalang doesn't work on Windows #55

NielsSteensma opened this issue Jul 27, 2024 · 0 comments

Comments

@NielsSteensma
Copy link
Owner

When using Dhalang on Windows the following error would appear originating from the JS scripts:
Unexpected token '\', "\{"webPage"... is not valid JSON

It's related to the fact that in Nodescriptinvoker.create_node_command#26 we call Shellwords.escape; this method is meant for Unix shells.

Action points:

  • State in documentation library doesn't work when using a non Unix shell.
  • Consider crossplatform shellword escaping ( like in Fastlane )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant