Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Amazon EventBridge + 2 convenience combinators #122

Merged
merged 10 commits into from
Jul 20, 2023

Conversation

bebyx
Copy link
Contributor

@bebyx bebyx commented Jul 19, 2023

This PR implements:

  • Amazon EventBridge type of detector notification (announcement, reference, API reference)
  • basic combinators for Equal and Not Equal operations, which come in handy in certain cases
  • tests for all of the above

@bebyx bebyx requested a review from a team as a code owner July 19, 2023 11:43
Copy link
Member

@jrduncans jrduncans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG

@bebyx bebyx force-pushed the feature/amazon-event-bridge branch 2 times, most recently from c4d136f to b1de6a8 Compare July 19, 2023 18:00
@bebyx bebyx requested a review from jrduncans July 19, 2023 18:05
CHANGELOG.md Outdated Show resolved Hide resolved
@bebyx bebyx force-pushed the feature/amazon-event-bridge branch from 3efed8b to 3efe4c1 Compare July 19, 2023 18:37
@bebyx bebyx requested a review from jrduncans July 19, 2023 18:45
@venky526 venky526 merged commit e454870 into Nike-Inc:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants