Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test function for the SE050 #5

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Add test function for the SE050 #5

merged 7 commits into from
Aug 24, 2023

Conversation

sosthene-nitrokey
Copy link

This PR adds a test function for the SE050 inside of the admin app.
This functionality is optional. It adds a new generic parameter for the Admin App that can either be an Se050 or the unit () type (default for backwards compatibility).

The SE050 test does:

  • Return SE050 firmware version
  • Return SE050 available memory
  • Test most of the functionality and report progress, so that any we can know where errors happen.

The test starts with a factory-reset of the device.

@sosthene-nitrokey
Copy link
Author

Corresponding nitropy update: Nitrokey/pynitrokey#423

For some reason the test also causes a hard fault in the FIDO tests that follow when run with nitropy.

@sosthene-nitrokey
Copy link
Author

The hard fault has been solved by Nitrokey/nitrokey-3-firmware#332

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe some code could be moved into a separate module to reduce the number of cfgs.

@sosthene-nitrokey
Copy link
Author

Looks good. Maybe some code could be moved into a separate module to reduce the number of cfgs.

Done

@sosthene-nitrokey sosthene-nitrokey merged commit fca96b5 into main Aug 24, 2023
@sosthene-nitrokey
Copy link
Author

TODO

  • Move SE050 tests to the SE050 backend so that it can be in the same firmware as the RNG backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants