Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nk3: Add get-config and set-config subcommands #448

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

robin-nitrokey
Copy link
Member

This PR adds the nk3 get-config and nk3 set-config subcommands to access the device configuration of a Nitrokey 3.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

Relevant Output Example

$ nitropy nk3 get-config fido.disable_skip_up_timeout                                                                                                                                                                                               
Command line tool to interact with Nitrokey devices 0.4.39                                                                                                                                                                                                                                
false                 

$ nitropy nk3 set-config fido.disable_skip_up_timeout true                                                                                                                                                                                          
Command line tool to interact with Nitrokey devices 0.4.39                                                                                                                                                                                                                                
Updated configuration fido.disable_skip_up_timeout.

$ nitropy nk3 get-config fido.disable_skip_up_timeout                                                                                                                                                                                               
Command line tool to interact with Nitrokey devices 0.4.39                                                                                                                                                                                                                                
true   

@robin-nitrokey robin-nitrokey marked this pull request as ready for review October 27, 2023 18:10
@daringer
Copy link
Collaborator

lgtm!

@robin-nitrokey robin-nitrokey merged commit ee5ff26 into master Oct 27, 2023
10 checks passed
@robin-nitrokey robin-nitrokey deleted the config branch October 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants